Skip to content

Conversation

@mgovers
Copy link
Member

@mgovers mgovers commented Dec 18, 2025

Cherry-picked from #1228

This investigates the possibilities of producing a reproducible build

Before merge (do-not-merge label)

Relates to #1190

Signed-off-by: Martijn Govers <[email protected]>
Signed-off-by: Martijn Govers <[email protected]>
Signed-off-by: Martijn Govers <[email protected]>
Signed-off-by: Martijn Govers <[email protected]>
Signed-off-by: Martijn Govers <[email protected]>
Signed-off-by: Martijn Govers <[email protected]>
Signed-off-by: Martijn Govers <[email protected]>
Signed-off-by: Martijn Govers <[email protected]>
Signed-off-by: Martijn Govers <[email protected]>
Signed-off-by: Martijn Govers <[email protected]>
Signed-off-by: Martijn Govers <[email protected]>
@mgovers mgovers self-assigned this Dec 18, 2025
@mgovers mgovers added do-not-merge This should not be merged improvement Improvement on internal implementation labels Dec 18, 2025
Signed-off-by: Martijn Govers <[email protected]>
@mgovers
Copy link
Member Author

mgovers commented Jan 12, 2026

Reproducible build on windows successful with both msvc and clang-cl in https://github.com/PowerGridModel/power-grid-model/actions/runs/20923965759/job/60116675758?pr=1240 (12a7fc4)

Signed-off-by: Martijn Govers <[email protected]>
Signed-off-by: Martijn Govers <[email protected]>
Signed-off-by: Martijn Govers <[email protected]>
@mgovers mgovers marked this pull request as ready for review January 13, 2026 10:35
@mgovers mgovers removed the do-not-merge This should not be merged label Jan 13, 2026
@mgovers
Copy link
Member Author

mgovers commented Jan 13, 2026

do-not-merge label removed because the reproducible build check passes in the nightly run https://github.com/PowerGridModel/power-grid-model/actions/runs/20953474927

Signed-off-by: Martijn Govers <[email protected]>
@mgovers
Copy link
Member Author

mgovers commented Jan 13, 2026

TonyXiang8787
TonyXiang8787 previously approved these changes Jan 13, 2026
@mgovers
Copy link
Member Author

mgovers commented Jan 13, 2026

Restarted Nightly in https://github.com/PowerGridModel/power-grid-model/actions/runs/20956375532

this nightly failed on the macos one. Investigating now.

Signed-off-by: Martijn Govers <[email protected]>
@mgovers
Copy link
Member Author

mgovers commented Jan 13, 2026

Restarted Nightly in https://github.com/PowerGridModel/power-grid-model/actions/runs/20956375532

this nightly failed on the macos one. Investigating now.

fix running in https://github.com/PowerGridModel/power-grid-model/actions/runs/20962280036

Signed-off-by: Martijn Govers <[email protected]>
Signed-off-by: Martijn Govers <[email protected]>
Signed-off-by: Martijn Govers <[email protected]>
Signed-off-by: Martijn Govers <[email protected]>
@mgovers
Copy link
Member Author

mgovers commented Jan 13, 2026

@sonarqubecloud
Copy link

@TonyXiang8787 TonyXiang8787 added this pull request to the merge queue Jan 13, 2026
Merged via the queue into main with commit e7b073d Jan 13, 2026
59 checks passed
@TonyXiang8787 TonyXiang8787 deleted the feature/reproducible-build branch January 13, 2026 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement Improvement on internal implementation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants